search

iNavFlight / inav-configurator

GNU General Public License v3.0
582 stars 314 forks source link

Servo number mismatch in configurator 2.3.1 #870

Closed Arvycka closed 4 years ago

Arvycka commented 4 years ago

Servo numbers in "Output mapping" section do not match servo numbers in "Servo mixer" section when a mixer preset is loaded. mixer

Why do we even need these servo numbers? Couldn't we just use Outputs? It complicates the mixer unnecessarily.

DzikuVx commented 4 years ago

They are not supposed to match. What you define in table is just an arbitrary number than later is converted to servo output number and actual output. On top of that, some internal functions relay on servo index. If you want numbers to match, index them from 0.

Arvycka commented 4 years ago

But now that's even more confusing than it was before - now we have 3 numbers for a servo, an output, a number below it and a number in the mixer. CLI uses mixer numbering. Output servo configuration also uses mixer numbering, but outputs are paired with different non matching numbers? How to track which servo is doing what? The presets should be updated too and not to assign a random servo number starting with 2 Also, at least in 2.2.1, servo autotrim ONLY works with default mapping from a preset. You can number the servos whatever you like and control and stabilization works fine, but servo autotrim only works correctly with default mapping. Has this been fixed in 2.3?

Oh, yes, the mixer preset image shows yet another set of meaningless numbers :D

2019-11-22, pn, 14:40 Paweł Spychalski notifications@github.com rašė:

They are not supposed to match. What you define in table is just an arbitrary number than later is converted to servo output number and actual output. On top of that, some internal functions relay on servo index. If you want numbers to match, index them from 0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iNavFlight/inav-configurator/issues/870?email_source=notifications&email_token=AGFWLI5VNWYWNDBHHP3MWZ3QU7HMHA5CNFSM4JQPAIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE5QSYQ#issuecomment-557517154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFWLI7MMJXV223T75DDHIDQU7HMHANCNFSM4JQPAIJQ .