iNavFlight / inav

INAV: Navigation-enabled flight control software
https://inavflight.github.io
GNU General Public License v3.0
3.09k stars 1.46k forks source link

SRXL2 or SRXLv2 Support #5265

Closed CloudsCapone closed 3 years ago

CloudsCapone commented 4 years ago

Current Behavior

<currently, I do not see available protocol to use the newer Spektrum SRXL2 receiver>

Desired Behavior

Suggested Solution

<If somewhat easily achievable, would be happy with a simple string of CLI commands for the time being.>

Who does this impact? Who is this for?

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label Feature request to this issue, with a confidence of 0.86. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

DzikuVx commented 4 years ago

Hi, So far Spectrum was not very eager to work with us to provide their radio protocols support in INAV. Without Spectrum assistance and probably hardware, INAV developers have zero to none chances to add support. I suggest contacting Spectrum customer center with a request to support iNAV

SpektrumRC commented 4 years ago

Unless we missed an email, I don't recall having been reached out to regarding this, other than some other posts on here from users requesting it. Our SRXL2 protocol is public and available at https://github.com/SpektrumRC/SRXL2 including both documentation and C library files. I had previously looked to see if it would have been quick enough to do a merge from betaflight srxl2 implementation into iNav, but there just seemed to be too many other changes/dependencies that are not yet merged to iNav, and unfortunately I've been too busy to make a new implementation specific to iNav's current state.

donsinger1 commented 4 years ago

Dzikuvx and SpektrumRC...I asked about this very issue and need in the RC Groups thread on the new SRXL2 receivers, specifically the 6610T and 637T....

I want to use the SRXL2 port on the 6610T to connect to a wing aware flight controller, such as a Matek 411WSE for an iNav build. I know it has been rolled out on Betaflight (4.1 and above), but wanted to know if there was a list of boards for iNav that had a target that included the SRXL2 protocol.

Andy Kunz replied that I should ask here and "bug the developers" to implement.

From your discussion, to the outsider, it looks like people are pointing fingers at each other, 'everyone is busy', so nothing gets done....It would be great if the development community would embrace Spektrum's new focus on openness and willing to cooperate with 3rd parties; and, I hope that Spektrum does not continue to be snarky as per the reply above and rather respond like 'well, never saw the email but let's work together to get this done'...

Can us users hope to see some progress on this issue? I do not want to have to purchase a FrSky system just to get this capability....

Thanks much for listening...Best, Don

MiguelFAlvarez commented 4 years ago

We've still been pretty swamped with stuff at work, but I've taken some personal time to work through adding this. VERY EXPERIMENTAL! Testing/Feedback would be appreciated though. @donsinger1 Not sure if a 6610T would work, as it handshakes slightly differently than the standalone serial receivers do.

https://github.com/MiguelFAlvarez/inav/releases/tag/2.3.0-SRXL2-TEST

donsinger1 commented 4 years ago

Hi Miguel:

You are a Prince!!!!

This would be fantastic if it worked on the 6610T…..I have one ready to test and a few blank Matek boards to try on…since I am doing a build right now, I can incorporate this with the FrSky RX with SBUS I had planned to use and test servos, esc, etc…will do the RX’s in parallel.

Can’t wait to play with this tonight.

Cordially, Don Singer KF7DS

From: MiguelFAlvarez notifications@github.com Sent: Wednesday, January 15, 2020 9:13 PM To: iNavFlight/inav inav@noreply.github.com Cc: donsinger1 donsinger@outlook.com; Mention mention@noreply.github.com Subject: Re: [iNavFlight/inav] SRXL2 or SRXLv2 Support (#5265)

We've still been pretty swamped with stuff at work, but I've taken some personal time to work through adding this. VERY EXPERIMENTAL! Testing/Feedback would be appreciated though. @donsinger1https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdonsinger1&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601402486&sdata=4SoYjtwkDcuOoaiGzNGLLvJ%2FLS4Ld2RMAR3KKQ1g8d8%3D&reserved=0 Not sure if a 6610T would work, as it handshakes slightly differently than the standalone serial receivers do.

https://github.com/MiguelFAlvarez/inav/releases/tag/2.3.0-SRXL2-TESThttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMiguelFAlvarez%2Finav%2Freleases%2Ftag%2F2.3.0-SRXL2-TEST&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601412499&sdata=2YMI20Zy89r%2ByrEiOeBJRKvMrVIK%2FoqZFBaGMYsnehA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FiNavFlight%2Finav%2Fissues%2F5265%3Femail_source%3Dnotifications%26email_token%3DAH64I3S2CNK27YZTLFW7CZLQ57UENA5CNFSM4JYY6V4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJCZSTI%23issuecomment-574986573&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601422503&sdata=NhhIE0NZGq2MIRXkoJx4HjIa9LtMYN1lUV2CT%2F%2BxdGs%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH64I3WQMNGTFGDLYH3LSX3Q57UENANCNFSM4JYY6V4A&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601422503&sdata=AHlF%2FdjlR652Rvjwvfy0c2PlZD3jLuk0o%2FXxr1FVqFI%3D&reserved=0.

donsinger1 commented 4 years ago

Hi Miguel:

I also have a few 4650s so will try those as well.

Don

From: MiguelFAlvarez notifications@github.com Sent: Wednesday, January 15, 2020 9:13 PM To: iNavFlight/inav inav@noreply.github.com Cc: donsinger1 donsinger@outlook.com; Mention mention@noreply.github.com Subject: Re: [iNavFlight/inav] SRXL2 or SRXLv2 Support (#5265)

We've still been pretty swamped with stuff at work, but I've taken some personal time to work through adding this. VERY EXPERIMENTAL! Testing/Feedback would be appreciated though. @donsinger1https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdonsinger1&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601402486&sdata=4SoYjtwkDcuOoaiGzNGLLvJ%2FLS4Ld2RMAR3KKQ1g8d8%3D&reserved=0 Not sure if a 6610T would work, as it handshakes slightly differently than the standalone serial receivers do.

https://github.com/MiguelFAlvarez/inav/releases/tag/2.3.0-SRXL2-TESThttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMiguelFAlvarez%2Finav%2Freleases%2Ftag%2F2.3.0-SRXL2-TEST&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601412499&sdata=2YMI20Zy89r%2ByrEiOeBJRKvMrVIK%2FoqZFBaGMYsnehA%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FiNavFlight%2Finav%2Fissues%2F5265%3Femail_source%3Dnotifications%26email_token%3DAH64I3S2CNK27YZTLFW7CZLQ57UENA5CNFSM4JYY6V4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJCZSTI%23issuecomment-574986573&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601422503&sdata=NhhIE0NZGq2MIRXkoJx4HjIa9LtMYN1lUV2CT%2F%2BxdGs%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH64I3WQMNGTFGDLYH3LSX3Q57UENANCNFSM4JYY6V4A&data=02%7C01%7C%7Cdc045a1c78e241b0f65608d79a42b50c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637147483601422503&sdata=AHlF%2FdjlR652Rvjwvfy0c2PlZD3jLuk0o%2FXxr1FVqFI%3D&reserved=0.

Romulusg commented 4 years ago

Has any of this been included in 2.4? Or do I need to use 2.3.0? Thanks for the work on this.

MiguelFAlvarez commented 4 years ago

Has any of this been included in 2.4? Or do I need to use 2.3.0? Thanks for the work on this.

I haven't received any feedback from anybody, and the only testing that has been done is from my own personal use (no issues so far), so I haven't made a merge request yet. As of right now, it's only available on 2.3 from the custom builds on my page. Haven't compiled for 2.4 yet since its still in the release candidate phase.

Romulusg commented 4 years ago

Thanks for the info. I will test it next weekend when I can. What type of feedback would you like?

Todd

On Feb 3, 2020, at 7:19 PM, MiguelFAlvarez notifications@github.com wrote:

 Has any of this been included in 2.4? Or do I need to use 2.3.0? Thanks for the work on this.

I haven't received any feedback from anybody, and the only testing that has been done is from my own personal use (no issues so far), so I haven't made a merge request yet. As of right now, it's only available on 2.3 from the custom builds on my page. Haven't compiled for 2.4 yet since its still in the release candidate phase.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

MiguelFAlvarez commented 4 years ago

@Romulusg Mainly just set it up and make sure it works properly (channel data, telemetry, rssi, failsafe detection) and doesn't cause any issues to otherwise normal operation like FC freezing/crashing. I only have F4 FC's so that's all I've tested personally. No idea if it works for F7's and F3's dont have enough flash to support the feature, so it's not implemented for those. Even if you test on F4's just be cautious and test everything on the bench. While it's not likely, its possible that some combination of features might cause an issue that I'm not seeing.

Romulusg commented 4 years ago

I wasnt able to test this weekend I couldnt get access to my srxl2 receiver. I ordered another one and will update as I test.

Romulusg commented 4 years ago

Hi Miguel,

I have loaded the hex file and copied the cli info. So far on my matekf411 wing FC everything appears working. controls function as expected and modes switch as well.

Auto launch works on the bench with a prop off and auto level is working as well

I havent tried RTH as it is on the bench.

So far it seems good.

I will try a flight when the windy chinook wind in calgary drops hopefully this weekend.

Romulusg commented 4 years ago

I installed the spm4650 spektrum rx and put it on TX1

one side note in the CLI the receiver is SRXL2 and it shows as valid but it doesnt appear in the receiver drop down. My guess it the array for the list range needs to be expanded by a row as it appears last in the list.

SpektrumRC commented 4 years ago

@Romulusg Thanks for the feedback. Look forward to hearing more. In regards to the configurator receiver drop down, it wont appear there until the configurator is also updated. For now, the cli is the only option to set this. I will make the appropriate configurator changes as well once a merge request for the protocol is submitted.

Romulusg commented 4 years ago

Ok additional testing this evening. I was able to enter the betaflight menu on the transmitter telemetry screen and change vtx settings as expected. another thumbs up.

SpektrumRC commented 4 years ago

@Romulusg btw, I compiled these changes onto the 2.4 release last night, but did not get a chance to test. Will try to test tonight and if it looks good on the bench, I'll upload that

trickapm commented 4 years ago

I can test a 4650 receiver with a matek f722 if i can get a link to the 2.4.0 builds?

trickapm commented 4 years ago

On the bench all looks well, didn't notice any issues. But i may not really know what to look for either ;-). I already bound it to my tx using the button on the pcb so didn't use the bind_rx command.

AntDX316 commented 4 years ago

need SRXL2 support on 2.4.1

Romulusg commented 4 years ago

@AntDX316 above there is a link to 2.4.0 there has not been an merge yet as far as @MiguelFAlvarez has mentioned in this page.

AntDX316 commented 4 years ago

@AntDX316 above there is a link to 2.4.0 there has not been an merge yet as far as @MiguelFAlvarez has mentioned in this page.

Do I have to reflash to the firmwares underneath the post or can I just drop the CLI in 2.4.1??

Romulusg commented 4 years ago

@MiguelFAlvarez can correct me if I’m incorrect but I believe the code needed for the flight controller hex files is in the link above. You would need to flash to that version as the cli commands are reliant on the code in the background.

AntDX316 commented 4 years ago

@MiguelFAlvarez can correct me if I’m incorrect but I believe the code needed for the flight controller hex files is in the link above. You would need to flash to that version as the cli commands are reliant on the code in the background.

There are a lot of files that are in the hex.. I'm sure it wasn't done individually? It much be an easy process to inject? Now, can we get the steps required to inject the code for it to work? Just incase the maker stops supporting for some reason?

Romulusg commented 4 years ago

@MiguelFAlvarez i flew my inav setup wing with the srxl2 receiver and everything worked seamlessly. How does this get merged?

donsinger1 commented 4 years ago

That is great…been way too busy the last three months to contribute, but glad to see there is substantial progress. Thanks Miguel and everyone else.

Stay safe.

Best Don Singer Portland, OR

From: Romulusg notifications@github.com Sent: Thursday, March 26, 2020 11:15 AM To: iNavFlight/inav inav@noreply.github.com Cc: donsinger1 donsinger@outlook.com; Mention mention@noreply.github.com Subject: Re: [iNavFlight/inav] SRXL2 or SRXLv2 Support (#5265)

@MiguelFAlvarezhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMiguelFAlvarez&data=02%7C01%7C%7C834e9f2284ed4d7e92e008d7d1b1a62e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637208433231495784&sdata=HzrffRFdt1oFt0SrfqPX4JrPY1D4OvyogcDdGWGcWmg%3D&reserved=0 i flew my inav setup wing with the srxl2 receiver and everything worked seamlessly. How does this get merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FiNavFlight%2Finav%2Fissues%2F5265%23issuecomment-604592892&data=02%7C01%7C%7C834e9f2284ed4d7e92e008d7d1b1a62e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637208433231495784&sdata=Mi3QrfHH7zB6HMNWo%2BouRBEfjDBs2tSJNVdY0XY6AjY%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH64I3WEUUFKOTZDHDKDXCDRJOLTTANCNFSM4JYY6V4A&data=02%7C01%7C%7C834e9f2284ed4d7e92e008d7d1b1a62e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637208433231505785&sdata=Hqllmexpi6mQiGM4pCHhiv5LRhYD018iRPblJxQha%2Bo%3D&reserved=0.

MiguelFAlvarez commented 4 years ago

I'll start doing pull requests for the necessary changes

MiguelFAlvarez commented 4 years ago

First pull request for uart idle callback support https://github.com/iNavFlight/inav/pull/5540 which is required for SRXL2 to work. Once that's merged, I will make a pull request for the SRXL2 support.

AntDX316 commented 4 years ago

First pull request for uart idle callback support #5540 which is required for SRXL2 to work. Once that's merged, I will make a pull request for the SRXL2 support.

Are you going to update it to 2.4.1?

MiguelFAlvarez commented 4 years ago

First pull request for uart idle callback support #5540 which is required for SRXL2 to work. Once that's merged, I will make a pull request for the SRXL2 support.

Are you going to update it to 2.4.1?

I'm making a pull request for the master branch. From there it should start getting included in upcoming releases. As for including it in my personal builds, I've only been compiling my changes on the latest release, and there is no 2.4.1 release yet unless I'm missing something, only 2.4.0. https://github.com/iNavFlight/inav/releases

AntDX316 commented 4 years ago

First pull request for uart idle callback support #5540 which is required for SRXL2 to work. Once that's merged, I will make a pull request for the SRXL2 support.

Are you going to update it to 2.4.1?

I'm making a pull request for the master branch. From there it should start getting included in upcoming releases. As for including it in my personal builds, I've only been compiling my changes on the latest release, and there is no 2.4.1 release yet unless I'm missing something, only 2.4.0. https://github.com/iNavFlight/inav/releases

What do you mean a pull request from the master branch? How long could that possibly take and is it even worth upgrading to 2.4.1 from 2.4.0? : )

MiguelFAlvarez commented 4 years ago

@AntDX316 I'm not sure how long it'll take. It's up to the inav devs when they have time to review/approve the code changes, and when they plan on making the next official release. I'm not sure where you're getting 2.4.1. There is no 2.4.1 inav release yet.

AntDX316 commented 4 years ago

@AntDX316 I'm not sure how long it'll take. It's up to the inav devs when they have time to review/approve the code changes, and when they plan on making the next official release. I'm not sure where you're getting 2.4.1. There is no 2.4.1 inav release yet.

2.4.1 has been out https://github.com/iNavFlight/inav-configurator/releases

MiguelFAlvarez commented 4 years ago

That is the configurator, not the firmware.

AntDX316 commented 4 years ago

That is the configurator, not the firmware.

so 2.4.0 that you put the SRXL2 on is the latest? : )

MiguelFAlvarez commented 4 years ago

That is the configurator, not the firmware.

so 2.4.0 that you put the SRXL2 on is the latest? : )

yup!

AntDX316 commented 4 years ago

That is the configurator, not the firmware.

so 2.4.0 that you put the SRXL2 on is the latest? : )

yup!

Works perfectly!

Romulusg commented 4 years ago

With the release of 2.5 has the merge of srxl2 been added? I dont see it in the release notes. Or is this fake https://github.com/iNavFlight/inav/wiki/2.5.0-Release-Notes @MiguelFAlvarez

MiguelFAlvarez commented 4 years ago

Not yet, the devs requested some changes to the code that I've just not had a chance to address

AntDX316 commented 4 years ago

Not yet, the devs requested some changes to the code that I've just not had a chance to address

Please have it where there is native SRXL2 support w/ no workaround.

Romulusg commented 4 years ago

Ok thanks for the update.

rickgode commented 4 years ago

Hi guys! I flashed the hex above to my matek 405 mini and using a SPM4650 Rx and it seems to work perfectly on the bench.

rickgode commented 4 years ago

Edit: I didn't see his 2.4.0 version. I just flashed that hex and everything still works.

Mine says

version INAV/MATEKF405 2.3.0 Jan 15 2020 / 22:30:44 (e5b5aad2c) GCC-9.2.1 20191025 (release) [ARM/arm-9-branch revision 277599]

Ricky

tourerjim commented 4 years ago

For Inav 2.5 could someone guide for the SRXL2 file so I can use my Sppedybee F4 with the SPM4650 receiver.

AntDX316 commented 4 years ago

What takes so long to get native SRXL2 support? Betaflight already has it.

tourerjim commented 4 years ago

For Inav 2.5 could someone guide for the SRXL2 file so I can use my Sppedybee F4 with the SPM4650 receiver.

I've now got my quad built and have Inav 2.5 loaded on the Speedybee FC but without the SRXL2 I can't complete it and just having retired would loved to get out and try it, I copped the above Cli SRXL2 file but doesn't work, Help

MiguelFAlvarez commented 4 years ago

@tourerjim inav doesn't officially support it yet. I'm working on that. You need a custom build from here in the meantime https://github.com/MiguelFAlvarez/inav/releases

Romulusg commented 4 years ago

@tourerjim inav doesn't officially support it yet. I'm working on that. You need a custom build from here in the meantime https://github.com/MiguelFAlvarez/inav/releases

@MiguelFAlvarez does that link and hex files then work with version 2.5?

Thanks