iNavFlight / inav

INAV: Navigation-enabled flight control software
https://inavflight.github.io
GNU General Public License v3.0
3.12k stars 1.47k forks source link

The beeper ouput pin is blocked by deactivated sources, other sources that are not deactivated cannot activate the beeper #9580

Open 1972linux opened 9 months ago

1972linux commented 9 months ago

Current Behavior

Although the beeper is switched on via an RX channel (Mode Beeper), the beeper output-pin does not work if, for example, the setting "beeper -HW_FAILURE" has been made and there is a hardware problem (e.g. connection to the GPS receiver is lost) or the setting "beeper - BAT_LOW" has been made and the battery is low.

Workaround: To ensure that the beeper can always be activated via RX-Chanel, you must activate all beeper sources with "beeper all".

Steps to Reproduce

  1. set "beeper -HW_FAILURE" on CLI
  2. Assign Mode Beeper to RX Chanel
  3. All Hardware without any problem, GPS-Receiver is connected and activated
  4. Activate Beeper via RC Chanel
  5. external Beeper is beeping
  6. Disconnect GPS-Receiver
  7. external Beeper stops beeping

Expected behavior

The beeper should not respond to deactivated sources, but other, non-deactivated sources can always switch on the beeper

Suggested solution(s)

change the logic to the expected behavior

b14ckyy commented 6 months ago

That does indeed not sound right. Good find.