Part 1, Step 3
The provided SimpleBrowser icons were not what is expected
Part 1, Step 7
The call to the super function of viewDidLoad() is already added upon project creation.
Part 1, Step 8
Had to assume that webView was a WKWebView outlet we had to create.
Also, need to import WebKitPart 1, Step 10let url = URL(string: "https://" + locationField!.text)! -> let url = URL(string: "https://" + locationField!.text!)!webView.loadRequest(URLRequest(URL: url)) -> webView.load(URLRequest(url: url))Part 1, Step 12
Add steps or reminders on how to use the protocol, or at least prompt the lab-er to make those changes.
class ViewController: WKNavigationDelegate
webView.navigationDelegate = self
*The next step similarly uses UITextFieldDelegate but does prompt the user.
Part 1, Step 13
let urlString:String = textField.text!
let url:URL = URL(string: urlString)!
let urlRequest:URLRequest = URLRequest(url: url)
webView.load(urlRequest)
->
let url = URL(string: "https://" + locationField!.text!)!
webView.load(URLRequest(url: url))
Part 2, First two code blocks
Indentation
Part 2, map blockT -> (T) in function parameter
Part 2, map usage exampleslet list -> list, since was already defined from previous examples
.append() is missing argument labels
.characters.count -> .countPart 2, filter blockT -> (T) in function parameter
Part 2, filter usage examples.characters.count -> .countPart 2, Testing
Remove class extensions since they are already implemented.
Users required to switch Swift version in build settings.
LinkedListsTests.swift - Line 9: Missing argument label
Suggestions
Part 2
I felt like it was a lot of reading/copy-paste. Maybe a couple easy try-it-yourself's could be incorporated
Add numbered steps
Timing
Part 1 - 1:15:32
Part 2 Implementation - 15:50
Part 2 Testing - 19:54
Changes
Part 1, Step 3 The provided SimpleBrowser icons were not what is expected Part 1, Step 7 The call to the super function of
viewDidLoad()
is already added upon project creation. Part 1, Step 8 Had to assume thatwebView
was aWKWebView
outlet we had to create. Also, need toimport WebKit
Part 1, Step 10let url = URL(string: "https://" + locationField!.text)!
->let url = URL(string: "https://" + locationField!.text!)!
webView.loadRequest(URLRequest(URL: url))
->webView.load(URLRequest(url: url))
Part 1, Step 12 Add steps or reminders on how to use the protocol, or at least prompt the lab-er to make those changes.class ViewController: WKNavigationDelegate
webView.navigationDelegate = self
*The next step similarly uses
UITextFieldDelegate
but does prompt the user. Part 1, Step 13->
Part 2, First two code blocks Indentation Part 2,
map
blockT
->(T)
in function parameter Part 2,map
usage exampleslet list
->list
, since was already defined from previous examples.append()
is missing argument labels.characters.count
->.count
Part 2,filter
blockT
->(T)
in function parameter Part 2,filter
usage examples.characters.count
->.count
Part 2, Testing Remove class extensions since they are already implemented. Users required to switch Swift version in build settings. LinkedListsTests.swift - Line 9: Missing argument labelSuggestions
Part 2 I felt like it was a lot of reading/copy-paste. Maybe a couple easy try-it-yourself's could be incorporated Add numbered steps
Timing
Part 1 - 1:15:32 Part 2 Implementation - 15:50 Part 2 Testing - 19:54