search

iOSDevLog / ijkplayer

Bilibili/ijkplayer cocoapods,iOS video player based on FFmpeg n3.3, with MediaCodec, VideoToolbox support.
GNU Lesser General Public License v2.1
79 stars 34 forks source link

Change to use github archive path #3

Closed Superbil closed 6 years ago

Superbil commented 6 years ago

Hello, I just change the podspece source to github archive path.

Next time you need release new version, just tag a new commit, and change the version on s.source. Don't need to zip framework again. 🎉

or use "https://github.com/iOSDevLog/ijkplayer/archive/#{s.version}.zip" to reference to spec.version number

BTW, use raw.githubusercontent.com is very slow when download zip.

jiaxianhua commented 6 years ago

https://github.com/iOSDevLog/ijkplayer/archive/#{s.version}.zip

this file does not contains full IJKMediaFramework.framework.

this is the content of IJKMediaFramework.framework/IJKMediaFramework

version https://git-lfs.github.com/spec/v1
oid sha256:1f7368690b353562ba77a04859ea1a38cad94e31dec5a36c81bb1cf4944ba995
size 118361496

So, I think I have to follow this link https://help.github.com/articles/creating-releases/, update the IJKMediaFramework.framework.zip file to release file.

Superbil commented 6 years ago

I see, that file need to use git-lfs to pull, cocoapods don't support git-lfs.

Change source to release file is the best way.