search

iOSDevTraining / books-and-movies

A simple app that pulls books (and movies) from a JSON feed, lists them in a table view, and shows detail about them.
iosdevtraining.com
MIT License
22 stars 13 forks source link

Memory Leak with NSURLSession #1

Open Eddpt opened 10 years ago

Eddpt commented 10 years ago

There seems to be a memory leak with NSURLSession. I was playing with Instruments and saw that NSURLSession tends to leak when you do stuff like rotating the screen and swapping between Master/Detail controllers.

screenshot 2014-01-24 22 25 00

It looks like it is a known issue: https://github.com/AFNetworking/AFNetworking/issues/1528

joshuatbrown commented 10 years ago

Thanks so much for finding and reporting this! I'd love to merge your fix so you get credit, but it looks like your master has other commits now, too. Would you create a feature branch with just this fix in it? I'd be happy to merge that in, then look at your other changes, too. I just like to have one pull request / merge per issue. Thanks again!

Eddpt commented 10 years ago

Ok I'll do that.