search

iP1SMS / disposable-phone-numbers

A list of disposable phone numbers
MIT License
59 stars 22 forks source link

Remove known fake numbers #8

Closed Wikxen closed 5 years ago

Wikxen commented 5 years ago

Resolves #6

brolaugh commented 5 years ago

Won't they just get picked up by the next scrape run?

Wikxen commented 5 years ago

Won't they just get picked up by the next scrape run?

Maybe they will, I got that these were his manual numbers and the other fakes are randomly generated. I don't know if he still posts the manual ones. Ask @jLynx.

This would be permanently solved by #7 and maybe a cleanup with the same validation.

jLynx commented 5 years ago

Not longer adding in manual ones. But it looks like its still picking up fake randomly generated ones like this one which was only added the other day: https://sms24.me/number-462153840016

Important to note that these are formatted as real numbers so there is no real way to tell that they are fake unless you call them and you get a disconnected message

brolaugh commented 5 years ago

Important to note that these are formatted as real numbers so there is no real way to tell that they are fake unless you call them and you get a disconnected message

Good thing is that Google's phone number library stores metadata about all the number plans of the world so it told me that the number +462153840016 was invalid.

If you want to play with it yourself here's a link

Currently we're adding all numbers that possible numbers but we could "tighten" it a bit by checking if the number matches any numbering plans in #7.

jLynx commented 5 years ago

Oh that's quite cool, I'll have a play with it!

jLynx commented 5 years ago

A few minutes they just added this one https://sms24.me/number-642145991704 which shows up as real on that site. So just keep that in mind. But still that's a pretty cool tool!

brolaugh commented 5 years ago

Thank you for the advice. In that case one would need to do a lookup to see if the number is in active use at which point it becomes very hard to know whether the number is disposable or not.

jLynx commented 5 years ago

Tbh it may be easier to just to add all the sites they are stealing numbers from and remove their site as they have no numbers of their own. Usually googling the number shows you the site it originated from. That's how I found out they were stealing my numbers

brolaugh commented 5 years ago

Tbh it may be easier to just to add all the sites they are stealing numbers from and remove their site as they have no numbers of their own.

But then we'd have to chase down all the websites our self and currently sms24.me is doing that for us allowing us to focus on other things. We're primarily using this list to block numbers during our signup process so I'm not sure what benefits there would be to us to find all the originating websites. With that said however, if your viewpoint as a provider of disposable phone numbers is different I'd like to hear it.

jLynx commented 5 years ago

I'm perfectly fine with this sort of list and it makes sense in a whole bunch of diffent application. I'm just trying to help out by making it more accurate. At the end of they day, it's run by you and you can handle it how you want to. Yes adding sms24 makes you job easier as they are already scraping numbers from most of the sites on the internet. But the issue is I am feeding them fake data which means this is also collecting fake data which could also potentially contain real numbers of individuals or again just take up space of storing fake numbers. If this is specifically for a website you run, then this may not have much of an impact as the chances of one of your users running into a blocked number they legitimately own is extremely low.

brolaugh commented 5 years ago

We're scraping a list of websites for phone numbers so wouldn't you be feeding us fake data too?

jLynx commented 5 years ago

Yes that's correct as I said that in my previous post. So that's why I suggested you find the list of other sites that sms24 is using then you won't be getting the fake data that sms24 is illegally scraping from my site and others.

The aim of the game for me is to full that site with as much crap as I can so their users find it unreliable and stop using it. That or they stop illegally scraping my site for numbers and messages. Since there is no way to contact them we just have to wait for them to realise.