Open Bindernews opened 4 years ago
I've just checked both the code for VST3 and also some compiled code on Mac with Ableton Live 10 and Reaper. If I set the kFlagCannotAutomate flag then the parameter doesn't turn up in automation lists.
Can you provide a project from which you can reproduce this? I am am unable to do so at present, and whilst I could test in windows I don't see why this should be platform-dependent, so ideally you'd confirm that you are able to reproduce at your end.
I am currently watching Reaper automate the number of graphs I have available as an LFO, which, if I had the parameter hooked up to anything, would cause a full UI redraw and a bunch of memory allocation/freeing. I'll see if I can get it down to a minimal example soon, but yes it's still an issue.
I've just added the flag to the single parameter in IPlugEffect and built for windows (10) in both 64 and 32 bit. I don't see the parameter in the automation list as a result. The code is very simple to tell the VST3 API that a parameter is automatable (and it is that way round - one must tell the API that it is rather than isn't automatable).
I can look at a bigger project, but from my testing so far, either:
1 - the situation is more complex than simply whether the flag is set 2 - something is weird in the version you have of REAPER (I'm probably a few versions back) and it's able to not respect the flag 3 - something in your build/testing procedure is not as you think it is and the flag is not correctly set in the version you are testing
When automation comes in from the host there is no filter that checks the parameter is automatable in iplug code, although it is possible that the VST3 SDK should be providing that - I don't know - but it's never been necessary in the past.
If you could test the simple case of adding the flag to iPlugEffect that would help point us towards which of the above possibilities are more/less likely.
I'll see about getting a minimal example with the bug. I'll also check FL Studio to see if it's there as well.
Thanks
Any update on this?
Here's a branch of BigLittleGain where I've set all parameters to have kFlagCannotAutomate
, yet I can still automate them in both Reaper and FL Studio.
https://github.com/Bindernews/BigLittleGain/tree/no-automation
I still can't reproduce on Mac with Reaper - just compiled from source. Will try on windows also.
This is what I get in reaper in the trim window:
Can you confirm:
Could you put a build up which exhibits the problem so I can check that?
Also no automatable parameters shown in Ableton Live.
AudioUnit is behaving as automatable in Live and Reaper - I'll investigate that.
OK - this looks like a bug in your code due to re initialising parameters without the automation flag in ReInitKnob().
I don't think there is an issue in iplug2 here - can I close?
For reference, @AlexHarker and I did some debugging and it seems that at least REAPER and FL Studio do not respect the relevant flags, meaning we need to file bug reports with REAPER, FL Studio, and potentially any other DAW that exhibits this behavior. I've already submitted a report to Image-Line, and I'm working with them to reproduce the bug. I'll file a report with REAPER soon.
More detail - REAPER respects in the trim menu, but not in the contextual menu/param menus on the plugin GUI.
Setup:
I can still automate the parameter in REAPER, but only when using VST3. VST2 is fine. Haven't tested anything else.