iPlug2 / iPlug2

C++ Audio Plug-in Framework for desktop, mobile and web
https://iplug2.github.io
Other
1.9k stars 282 forks source link

Remove the special entry in the index for CLAP submodules on the cmake-branch #890

Closed erikgrahn13 closed 2 years ago

erikgrahn13 commented 2 years ago

Describe the bug When cloning the repo and updating submodules on the cmake branch An error occurs with fetching submodules of CLAP that someone probably has stored in their local git index and accidently commit.

From https://github.com/iPlug2/iPlug2

To Reproduce

  1. clone iPlug2 repo
  2. run git submodule update --init --recursive

Expected behaviour The CLAP_HELPERS and CLAP_SDK should not be stored in the modules/index unless they are specified as submodules in a .gitmodules file and provided with a proper url

Screenshots If applicable, add screenshots to help explain your problem.

IMPORTANT DETAILS Relates to ALL platforms Additional context Add any other context about the problem here.

AlexHarker commented 2 years ago

The CLAP_HELPERS and CLAP_SDK were included in the clap branch which is for work in progress on clap support. It was set up for me to work on and intended to be carefully merged into master once the work is complete (which may not involve submodules, as other bits of IPlug2 are not done that way, but require a different approach, such as manual cloning).

I'm not sure how the cmake branch has come into being or been updated (as I haven't worked on it), but it looks like it has merged in changes for the clap branch (including very recent changes), which may or may not be in a finally mergeable state.

@olilarkin - can you shed any light on what's happened in terms of the history so we can ensure the correct solution?

olilarkin commented 2 years ago

cmake and clap brances are both WIP and will be merged carefully. however thanks for the heads up