search

iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
455 stars 115 forks source link

Incompatible with Twilight Forest #1133

Open qouteall opened 2 years ago

qouteall commented 2 years ago

https://streamable.com/mlud9n

qouteall commented 2 years ago 
 java.lang.IndexOutOfBoundsException: readerIndex(6359) + length(1) exceeds writerIndex(6359): UnpooledHeapByteBuf(ridx: 6359, widx: 6359, cap: 6359/6359)
    at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442) ~[netty-all-4.1.68.Final.jar:?]
    at io.netty.buffer.AbstractByteBuf.readByte(AbstractByteBuf.java:730) ~[netty-all-4.1.68.Final.jar:?]
    at net.minecraft.network.FriendlyByteBuf.readByte(FriendlyByteBuf.java:1013) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.FriendlyByteBuf.readVarInt(FriendlyByteBuf.java:344) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.FriendlyByteBuf.readLongArray(FriendlyByteBuf.java:269) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.FriendlyByteBuf.readLongArray(FriendlyByteBuf.java:265) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.world.level.chunk.PalettedContainer.read(PalettedContainer.java:163) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.world.level.chunk.LevelChunkSection.read(LevelChunkSection.java:170) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.world.level.chunk.LevelChunk.replaceWithPacketData(LevelChunk.java:445) ~[minecraft-project-@-merged-named.jar:?]
    at qouteall.imm_ptl.core.chunk_loading.MyClientChunkManager.replaceWithPacketData(MyClientChunkManager.java:121) ~[imm_ptl_core-v1.4.8-1.18.jar:?]
    at net.minecraft.client.multiplayer.ClientPacketListener.updateLevelChunk(ClientPacketListener.java:661) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.client.multiplayer.ClientPacketListener.handleLevelChunkWithLight(ClientPacketListener.java:656) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.protocol.game.ClientboundLevelChunkWithLightPacket.handle(ClientboundLevelChunkWithLightPacket.java:45) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.protocol.game.ClientboundLevelChunkWithLightPacket.handle(ClientboundLevelChunkWithLightPacket.java:12) ~[minecraft-project-@-merged-named.jar:?]
    at net.minecraft.network.protocol.PacketUtils.method_11072(PacketUtils.java:22) ~[minecraft-project-@-merged-named.jar:?]
    at qouteall.imm_ptl.core.ClientWorldLoader.lambda$withSwitchedWorld$11(ClientWorldLoader.java:486) ~[imm_ptl_core-v1.4.8-1.18.jar:?]
    at qouteall.imm_ptl.core.ClientWorldLoader.withSwitchedWorld(ClientWorldLoader.java:468) ~[imm_ptl_core-v1.4.8-1.18.jar:?]
    at qouteall.imm_ptl.core.ClientWorldLoader.withSwitchedWorld(ClientWorldLoader.java:485) ~[imm_ptl_core-v1.4.8-1.18.jar:?]
qouteall commented 2 years ago

Update: I tested the latest Fabric version twilight forest with ImmPtl and the chunk loading issue seems fixed.

But there is a new issue that causes crash:

java.lang.AbstractMethodError: Missing implementation of resolved method 'abstract int modifyColor(double, double, int)' of abstract class net.minecraft.world.level.biome.BiomeSpecialEffects$GrassColorModifier.
    at net.minecraft.world.level.biome.Biome.getGrassColor(Biome.java:275)
    at net.minecraft.client.multiplayer.ClientLevel.calculateBlockTint(ClientLevel.java:796)
    at net.minecraft.client.multiplayer.ClientLevel.method_38538(ClientLevel.java:112)
    at net.minecraft.client.color.block.BlockTintCache.getColor(BlockTintCache.java:91)
    at net.minecraft.client.multiplayer.ClientLevel.getBlockTint(ClientLevel.java:778)
    at net.minecraft.client.renderer.chunk.RenderChunkRegion.getBlockTint(RenderChunkRegion.java:67)
    at net.minecraft.client.renderer.BiomeColors.getAverageColor(BiomeColors.java:14)
    at net.minecraft.client.renderer.BiomeColors.getAverageGrassColor(BiomeColors.java:18)
    at net.minecraft.client.color.block.BlockColors.method_1693(BlockColors.java:48)
    at net.minecraft.client.color.block.BlockColors.getColor(BlockColors.java:112)
    at net.minecraft.client.renderer.block.ModelBlockRenderer.putQuadData(ModelBlockRenderer.java:134)
    at net.minecraft.client.renderer.block.ModelBlockRenderer.renderModelFaceAO(ModelBlockRenderer.java:120)
    at net.minecraft.client.renderer.block.ModelBlockRenderer.tesselateWithAO(ModelBlockRenderer.java:77)
    at net.minecraft.client.renderer.block.ModelBlockRenderer.tesselateBlock(ModelBlockRenderer.java:48)
    at net.minecraft.client.renderer.block.BlockRenderDispatcher.renderBatched(BlockRenderDispatcher.java:61)
    at net.minecraft.client.renderer.chunk.ChunkRenderDispatcher$RenderChunk$RebuildTask.redirect$cbf000$hookChunkBuildTesselate(ChunkRenderDispatcher.java:791)
    at net.minecraft.client.renderer.chunk.ChunkRenderDispatcher$RenderChunk$RebuildTask.compile(ChunkRenderDispatcher.java:578)
    at net.minecraft.client.renderer.chunk.ChunkRenderDispatcher$RenderChunk$RebuildTask.doTask(ChunkRenderDispatcher.java:489)
    at net.minecraft.client.renderer.chunk.ChunkRenderDispatcher.method_22757(ChunkRenderDispatcher.java:140)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run$$$capture(CompletableFuture.java:1768)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java)
    at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
    at java.base/java.util.concurrent.ForkJoinTask.doExec$$$capture(ForkJoinTask.java:373)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Zarepheth commented 2 years ago

I've currently got Immersive Portal (Fabric) running with Twilight Forest (Fabric). So far, no problems, but I've not been inspecting the logs for non-crash errors.

I've been able to travel between overworld and nether via two currently active portals (both are Immersive Portal portals that are operating correctly). I also have one active portal between the overworld and the twilight forest. This is a normal Twilight Forest portal, no Immersive Portal effects, and it also operates correctly.

I suppose I should try a nether portal from the twilight forest and see what happens... (or maybe I shouldn't???)

My Curse Forge profile on the Overwolf client is based upon the "Better MC [FABRIC] 1.19.2 v9" mod pack, though I've added lots of mods beyond what @xSHXRKIEx put in it.

Adzeiros commented 1 year ago

I've currently got Immersive Portal (Fabric) running with Twilight Forest (Fabric). So far, no problems, but I've not been inspecting the logs for non-crash errors.

I've been able to travel between overworld and nether via two currently active portals (both are Immersive Portal portals that are operating correctly). I also have one active portal between the overworld and the twilight forest. This is a normal Twilight Forest portal, no Immersive Portal effects, and it also operates correctly.

I suppose I should try a nether portal from the twilight forest and see what happens... (or maybe I shouldn't???)

My Curse Forge profile on the Overwolf client is based upon the "Better MC [FABRIC] 1.19.2 v9" mod pack, though I've added lots of mods beyond what @xSHXRKIEx put in it.

How did you get Immersive Portals to work with Better MC? Mine crashes anytime I launch with this mod.

Zarepheth commented 1 year ago

How did you get Immersive Portals to work with Better MC? Mine crashes anytime I launch with this mod.

I did not do anything special. I just added it via the CurseForge Overwolf client.

I have not used that profile for several weeks, as I'm currently playing some other games. When I finish with these games, and probably finish reading some novels, I'll likely return to Minecraft.

@Adzeiros : Do you have crash logs when combining Immersive Portals with the Better MC mod pack? And is it the same version and edition as I'm using?