iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
445 stars 107 forks source link

"/portal euler set_other_side" sets portals upsidedown #1235

Closed Vexxen1 closed 1 year ago

Vexxen1 commented 1 year ago

According to your testing, does the issue occur with ONLY Immersive Portals mod and Farbic API?

Yes

Describe the issue

Run the command: /execute as @e[type=immersive_portals:portal,sort=nearest,limit=1] run portal euler set_other_side ~ ~ ~ ~ ~ it will set the rotation upside down.

Post the log here

No response

Vexxen1 commented 1 year ago

Sorry for the issue spam, put it all into 1 issue, you can delete this post: https://github.com/iPortalTeam/ImmersivePortalsMod/issues/1236

qouteall commented 1 year ago

Currently the euler angle rotation correspond to the other side's facing rotation. You want it to be the opposite?

qouteall commented 1 year ago

I see what do you mean by upside down now.

qouteall commented 1 year ago

The upside-down issue is caused by the mod's reverse portal entity linking rule. ImmPtl currently flips axisH to create the flipped and reverse portal. Changing it to axisW will fix the upside-down issue, but also change existing portal linking status and may break the portals of existing worlds.

qouteall commented 1 year ago

fixed