search

iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
435 stars 103 forks source link

Crash with rlsl #1256

Closed spaghettube closed 1 year ago

spaghettube commented 1 year ago

According to your testing, does the issue occur with ONLY Immersive Portals mod and Farbic API?

No

Describe the issue

i've reported the issue to another dev and they directed me to here, original issue. Something related to sounds they said

Post the log here

on the linked issue ^^
qouteall commented 1 year ago

Probably fixed in ImmPtl 2.4.9

spaghettube commented 1 year ago

what about in "immersive-portals-2.3.1-mc1.19.2-fabric.jar"?

spaghettube commented 1 year ago

tested, and no, still broken on that version

qouteall commented 1 year ago

@spaghettube Do you mean that it still crashes in 2.4.9? Post the new crash report.

The fix is not backported to 1.19.2. The 2.3.1 was an old version that was not released on CurseForge. Only 1.19.3 is maintained for now because development effort is limited.

qouteall commented 1 year ago

The packet handling should normally occur in client thread, so accessing the random won't cause an issue. However the packet is acually handled from networking thread. This may be caused by other optimization mods.

I tested ImmPtl 2.4.9 with RLSL and it doesn't crash. Close issue for now. However, there may be some optimization mods that interfere with this issue. If you find a three-mod incompatibility issue, open another issue.

spaghettube commented 1 year ago

@spaghettube Do you mean that it still crashes in 2.4.9? Post the new crash report.

The fix is not backported to 1.19.2. The 2.3.1 was an old version that was not released on CurseForge. Only 1.19.3 is maintained for now because development effort is limited.

I have not tested 2.4.9 as I'm stuck on 1.19.2 for now. I meant it was still the same on the latest 1.19.2, 2.3.1. If it's fixed on 1.19.3 I'm glad, and I'll just have to hope that you'll eventually decide to port the fix to 1.19.2. Thanks regardless :)

Edit: Misunderstood the whole situation. So a third mod should be interfering with ImmPtl and RSLS? Well if I do figure out which one is doing that I'll open a new issue. Any lead to what I should be looking for?