search

iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
450 stars 108 forks source link

Incompatible with Textile Backup #1402

Closed xMathayus closed 1 year ago

xMathayus commented 1 year ago

Is it a mod compatibility issue?

Yes

Minecraft version

1.20.1

Describe the issue

The latest Aug 4 Update is no longer compatible with Textile Backup Mod.

qouteall commented 1 year ago

https://github.com/Szum123321/textile_backup

qouteall commented 1 year ago

The cause is that Textile Backup is doing non-thread-safe operations. ImmPtl's assertion is triggered in that non-thread-safe operation and cause the backup process to abort. This is primarily an issue of Textile Backup, but manifests when ImmPtl is installed. Even without ImmPtl, the non-thread-safe operation could cause rare bugs in Textile Backup (the change of bugs are very rare so it's usually unnoticed).

qouteall commented 1 year ago

In the latest version, the assertion has been changed to non-exception-throwing. So the issue does not manifest. But the thread safety of Textile Backup still exists.

xMathayus commented 1 year ago

Thank you. seems to be working again