iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
422 stars 100 forks source link

Unbreakable blocks in dimension below player's dimension when that dimension's height is high #1465

Closed SuperCatMaster closed 8 months ago

SuperCatMaster commented 8 months ago

Is it a mod compatibility issue?

No

If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)

No response

Minecraft version

1.20.1

Describe the issue

When I try to break a block in the dimension below overworld, it doesn't breaks. Idk, maybe it because my custom datapack dimension (inside my custom mtweaks mod), but with nether it works fine on 1.20,2 Here's a video with a bug. Here's log. Here's mods and configs.

qouteall commented 8 months ago

Collective is reported to have compat issues with ImmPtl. Does the issue occur with only ImmPtl, mtweaks and Fabric API?

I can reproduce the issue

qouteall commented 8 months ago

I tested dimension stack with this dimension datapack https://modrinth.com/datapack/deeper_dark/version/2.2.1 and it works normally. This is probably caused by speciality of mtweaks.

SuperCatMaster commented 8 months ago

Well, in mtweaks there are no mixins with blocks nor dimensions. mtweaks is used to load datapacks with dimensions (I test some mtweaks features in the IDE), so the problem is clearly not mtweaks. I also tested the datapack only stiuation and the problems occurred again. I used the misode tool to create the datapacks, so I don't think there will be any problems. Maybe because of the height of the world? This is about 800 blocks.

qouteall commented 8 months ago

Can you upload the datapack so that I can test it?

SuperCatMaster commented 8 months ago

tarta.zip There it is. Have to work with uploaded configs.

qouteall commented 8 months ago

I can reproduce the issue with only the datapack

qouteall commented 8 months ago

I found that it's caused by a mistake in code

https://github.com/iPortalTeam/ImmersivePortalsMod/commit/16e5784562bceb5a0f1b111f15c02ed2d15b69bd

Now fixed. You are correct that the bug is triggered because of the height.

qouteall commented 8 months ago

fixed in 3.3.5 https://modrinth.com/mod/immersiveportals/version/v3.3.5-mc1.20.1