iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
421 stars 100 forks source link

Valkyrien skies compat #1530

Open TecnoNV opened 3 months ago

TecnoNV commented 3 months ago

Is it a mod compatibility issue?

Yes

If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)

https://www.curseforge.com/minecraft/mc-mods/valkyrien-skies

Minecraft version

1.18.x

Describe the issue

I wrote this not only for reporting an issue but for making a suggestikn too because Valkyrien skies is a really great mod, but unfortunately when I add immersive portals to the mod folders the ship assembling feature (from VS) doesn't work properly. I think you should make compat with this mod because it is really great and it would pair greatly with immersive portals.

TecnoNV commented 3 months ago

More about the issue: https://github.com/iPortalTeam/ImmersivePortalsMod/issues/1252 https://discord.com/channels/244934352092397568/1135335132505587862

pama1234 commented 2 months ago

This is what I tried. Using F3+B to view hitbox, we can see that valkyrien skies ship entity has not really disappeared. When summoning creatures (such as cows) on an invisible ship, the creatures can still move normally on the ship. When the player gets stuck on the ship, teleporting the player to higher places like "~ ~30 ~", we can see that the player's falling speed does not gradually increase from 0, but will already be the highest falling speed (unlike jumping from high places)

image

I am trying to solve the compatibility issue of Valkyrie's Sky Mod, and I am still reading the source. It is likely the issue is with the ship entity at client-side, maybe somewhere in the mixins.

TecnoNV commented 1 month ago

This is what I tried. Using F3+B to view hitbox, we can see that valkyrien skies ship entity has not really disappeared. When summoning creatures (such as cows) on an invisible ship, the creatures can still move normally on the ship. When the player gets stuck on the ship, teleporting the player to higher places like "~ ~30 ~", we can see that the player's falling speed does not gradually increase from 0, but will already be the highest falling speed (unlike jumping from high places)

image

I am trying to solve the compatibility issue of Valkyrie's Sky Mod, and I am still reading the source. It is likely the issue is with the ship entity at client-side, maybe somewhere in the mixins.

Thanks for the information, but may I know if you are doin an addon ( to address the mentioned issue ) or smth like that? If so, please reply and provide a download for such addon. Im begging you 😭😭😭