search

iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
446 stars 106 forks source link

[Fabric][1.17.1] Crash with Iris-starline when shader is disabled #884

Closed DerLeole closed 2 years ago

DerLeole commented 2 years ago

This happens in likely all versions released right now (tested up to 0.31) for fabric 1.17.1.

Issue and Reproduction: Game crashes whenever no shader pack is selected or shaders are turned off. The game works fine when any shader pack is loaded and active. Game crashes only when either a world is loaded without any shader pack, or the shader pack is turned off while playing.

Environment: This only happens when used in a mod constellation that includes at least: Immersive Portals 1.17.1 (0.31-) Sodium 1.17.1 (0.3.2) Iris-starline (1.1.3 - build 639) (Link) Fabric Loader 0.12.5

Detailed Crash Report: https://crashy.net/1sisi2lc4kDITwlTQeKw

Link to issue on Iris-starline page: https://github.com/HyperCubeMC/Iris/issues/37

Justsnoopy30 commented 2 years ago

This is because iris now uses mixin-based sodium compat, and immersive portals will need changes to work with it. This shouldn't be specific to starline and should happen on the latest upstream Iris commits too.

qouteall commented 2 years ago

only official iris is being considered