iPortalTeam / ImmersivePortalsModForForge

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
43 stars 18 forks source link

Fix structures spawning in void dimension #120

Closed littlej541 closed 1 year ago

littlej541 commented 1 year ago

Currently, structures such as villages spawn in the void dimension provided by this mod. This is caused by the empty optional being passed into the FlatLevelGeneratorSettings constructor. If the optional isn't present, as it is not with Optional.empty() being passed in, ChunkGenerator falls back to a default structure set rather than using an empty structure overrides list as is intended.

This fix is already in the latest Fabric version, as seen here:

https://github.com/iPortalTeam/ImmersivePortalsMod/blob/55c9c1e7e298e09d8d43b0114e64e30271aa43b6/src/main/java/qouteall/imm_ptl/peripheral/alternate_dimension/AlternateDimensions.java#L179

Since this fix is not in this or the latest Forge branch, it should probably be cherrypicked into that branch as well.