iPortalTeam / ImmersivePortalsModForForge

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
38 stars 17 forks source link

Map Atlases Incompatibility #74

Open PotionSeeker opened 1 year ago

PotionSeeker commented 1 year ago

According to your testing, does the issue occur with ONLY Immersive Portals mod installed?

No

Forge Version

43.2.0

ImmersivePortals Version

2.3.1-SNAPSHOT-2-mc1.19.2

Latest Log

https://gist.github.com/PotionSeeker/8dd39da070614afc6cfdb5e0c973e2ef

Crash Report (if applicable)

https://gist.github.com/PotionSeeker/eccfa4ad8abb946d668319caaf2f9a0d

Steps to Reproduce

  1. Start a new world
  2. Either create an Atlas or spawn one in via creative mode
  3. Place the atlas in the hotbar

What You Expected

Having a map atlas on the hotbar should open up a minimap in the top left corner and right clicking should open up a larger map.

This is what it should look like: map_atlas functioning

What Happened Instead

When an atlas is placed on the hotbar, the game crashes.

Additional Details

No response

Please Read and Confirm The Following

qouteall commented 1 year ago

ImmPtl has a mechanism of wrapping packet as redirected packet (in MixinServerGamePacketListenerImpl_E). This issue may be related to that.

qouteall commented 1 year ago

Seems that Map Atlas is not doing its networking in normal way (not using custom payload packet). Forge and Fabric's networking API all use custom payload packet internally. If Map Atlas does networking in normal way, this should get fixed.

PotionSeeker commented 1 year ago

So for the time being it's more like a fundamental incompatibility than a bug. That's a shame.

qouteall commented 1 year ago

https://github.com/iPortalTeam/ImmersivePortalsMod/issues/1140