Closed Tjoosten closed 9 years ago
@Tjoosten Thanks a lot! Again a good quality pull request :) Only one todo left: delete .idea
in your pull request please
@Tjoosten Regarding future: it might be good to have a style-ci with a git pre commit hook? Do you know how to do that?
@brechtvdv This repo is maintained by you so I'll leave the merging to you. What I'm concerned this can be merged as long as my first comment to @Tjoosten is dealt with first.
@pietercolpaert Joosten is my lastname... And i can do know how to do that. But i needed the rights of the repo for that. So maybe @brechtvdv or you can do it?
And the .idea folder is removed.
Looks great @Tjoosten !
Misc. Changes
array()
attributes to[ ]
..idea
to.gitignore
- #48Fixed PSR-2 Violations.
if()
->if ()
Fixes:
.idea
folder.vendor/autoload.php
to../vendor/autoload.php
.Notes
[19/08/2015 - 19:01h] Please don't close it. I'm still working on this. [20/08/2015 - 12:00h] @pietercolpaert: i'm ready. If you want you can merge this.