search

iRail / stations

A list of all the Belgian stations and their properties used within the iRail project
http://irail.be/stations/NMBS
30 stars 20 forks source link

Fix bugs #128 and #129 in Stations.php #130

Closed Bertware closed 6 years ago

Bertware commented 6 years ago

Bug #128 fixed: Dashes and spaces are correctly sanitized Bug #129 fixed: When an exact match is found, the exact match will be at index 0 in the array. Partial matches can be found in the next indices.

This PR includes fixes for both issues, tests to ensure these issues won't occur again, and general improvements to readability and remove code duplication by moving 2 complex if-statements to their own function.

PHPUnit might fail on a broken dependency for PHP 7.2: https://github.com/lanthaler/JsonLD/issues/88 https://github.com/lanthaler/JsonLD/pull/92

pietercolpaert commented 6 years ago

This is a neat PR! Thanks!