Improvements - Githubissues

iRail / stations

A list of all the Belgian stations and their properties used within the iRail project

http://irail.be/stations/NMBS

29 stars 20 forks source link

Improvements #70

Closed Tjoosten closed 8 years ago

Tjoosten commented 8 years ago

Several improvements. See the commits for more info

pietercolpaert commented 8 years ago

I'd rather see pull requests that do something specific instead of something general like "improvements". For me, this should have been 2 pull requests:

Adding PHP versions to travis.ci
reformatting javascript code

What coding standards did you use to reformat the javascript? Jshint?

Tjoosten commented 8 years ago

Nodelint and sorry i will paying attention on that

pietercolpaert commented 8 years ago

I won't merge this as I would like to keep the 2 spaces indent for javascript. We're following the code standards of @rubenverborgh here, such as in https://github.com/RubenVerborgh/N3.js. I'd prefer reusing his linter over here: https://github.com/RubenVerborgh/N3.js/blob/master/.eslintrc