Implemented station weight/importance

iRail / stations

A list of all the Belgian stations and their properties used within the iRail project

http://irail.be/stations/NMBS

29 stars 20 forks source link

Implemented station weight/importance #76

Closed Bertware closed 8 years ago

Bertware commented 9 years ago

Implemented #22

Bertware commented 9 years ago

Started work on failed checks. PHPUnit on my system is returning all passed though. Manual tests are also resulting correct (sorted) results. @pietercolpaert can you look into the failing phpunit? My results:

PHPUnit 3.7.28 by Sebastian Bergmann.
Configuration read from /home/bert/Documents/Code/stations/phpunit.xml
.....
Time: 1.01 seconds, Memory: 11.25Mb
OK (5 tests, 18 assertions)

pietercolpaert commented 9 years ago

I left some in-line comments. I believe travis will run okay if these comments are handled.

Furthermore, could you squash these commits into 1? Will make a nicer history instead of different trial and errors :) See http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Thanks a lot for this PR already! Very nice! /giphy Borat thumbs up

pietercolpaert commented 9 years ago

If you don't feel like implementing the avgStopTimes per day per stop, I would merge these changes on the conditions that:

[ ] You don't map the vehicle frequency to a URI, but you just add it into the JSON object itself as vehiclefrequency
[ ] We make a new issue which described that short comings of the current scripts (not taking into account the importance of a stop time rule) and suggest to switch to an average stop times per day number

Bertware commented 9 years ago

I'll try to implement it based on the calendar dates, I'll look into it this weekend :)

brechtvdv commented 9 years ago

@Bertware Feel free to use this repo: https://github.com/brechtvdv/gtfs2arrdep It loads GTFS feed into a MySQL db. Then you can write a script, similar to this one. It's your choice :)

pietercolpaert commented 9 years ago

@Bertware Thanks for the rebasing and for changing it to daily average stoptimes! Appreciate it a lot!

pietercolpaert commented 9 years ago

@Bertware one thing left to do: also change the CSV header to avg_stop_times and update the README.md.

Bertware commented 9 years ago

@pietercolpaert can you take a look at this? :)

pietercolpaert commented 9 years ago

Sorry, was on holiday! Will check later this week. Looks good on first sight!

pietercolpaert commented 9 years ago

Heads up: still going to merge this! Didn't forget this!