search

iRail / stations

A list of all the Belgian stations and their properties used within the iRail project
http://irail.be/stations/NMBS
29 stars 20 forks source link

Fallback station names with ' as whitespace #81

Closed brechtvdv closed 8 years ago

brechtvdv commented 8 years ago

Fixes: http://api.irail.be/vehicle.php/?id=3468&lang=fr&date=261115&time=1901&format=JSON

pietercolpaert commented 8 years ago

This should be fixed differently:

  1. Write a test in the tests which add the name which fails to resolve
  2. Make sure the in the regular expression in the PHP code, a ' can also be a whitespace

Reason why I will not accept this: what you wrote in the fields for the different languages are not translations, but are different ways of writing it, without a clear language difference.

pietercolpaert commented 8 years ago

In production!

brechtvdv commented 8 years ago

:bowtie: