iRoachie / react-native-material-tabs

Material Design implementation of Tabs
MIT License
121 stars 56 forks source link

Improve performance? #11

Closed FezVrasta closed 6 years ago

FezVrasta commented 6 years ago

I notice quite some lag with this component (when it animates), is there any chance to get some performance boost somehow?

iRoachie commented 6 years ago

Hey @FezVrasta which platform did you experience this on? Also what’s our react-native version?

FezVrasta commented 6 years ago

I used the latest Expo react-native fork, I experienced lag especially on iPhone 6, but also on Android.

The one with less lag was the iPhone X simulator, but still in some cases it did lag.

iRoachie commented 6 years ago

I'm not experiencing this behavior, see a video I just made https://youtu.be/fDU9dOqRUpw. This is on iPhone 6

FezVrasta commented 6 years ago

I guess it has to do with the amount of work done while the tab is changing. Are you using native driven animations?

iRoachie commented 6 years ago

Just updated it to! https://github.com/iRoachie/react-native-material-tabs/pull/12

FezVrasta commented 6 years ago

Great thanks!

iRoachie commented 6 years ago

Live! v3.1.0