Two tests are failing now due the the changes in Tab.js, now there is a minor block stateless component TabItem, I was thinking about the logic to show the vertical/horizontal(label+element) and thought that splitting this if/else/styling questions into a minor stateless component was more easy to understand.
NOTE: PLEASE, DO NOT MERGE YET, STILL WIP
Now we can pass two props when passing an Element, text and vertical, as the name says if we pass the text will show by default the Element + text horizontally, and if we pass vertical(value true) the Element + text will be shown vertically, in this order as the image above shows up.
I would like to change the two failing tests to match the new changes, I think this won't be a breaking change to the lib, just the shallow navigation inside of the component is messy right now. So, may I change those 2 failing tests and add 2-3 more tests for the new features?
Hey @araujobarret I recently updated the lib in 4.0.0 as a typescript rewrite and 4.1.0 that cleans up the logic and supports rtl. You would have tor resubmit this PR.
Hi,
this PR closes #34
Two tests are failing now due the the changes in Tab.js, now there is a minor block stateless component TabItem, I was thinking about the logic to show the vertical/horizontal(label+element) and thought that splitting this if/else/styling questions into a minor stateless component was more easy to understand.
NOTE: PLEASE, DO NOT MERGE YET, STILL WIP
Now we can pass two props when passing an Element, text and vertical , as the name says if we pass the text will show by default the Element + text horizontally, and if we pass vertical(value true) the Element + text will be shown vertically, in this order as the image above shows up.
how to use:
I would like to change the two failing tests to match the new changes, I think this won't be a breaking change to the lib, just the shallow navigation inside of the component is messy right now. So, may I change those 2 failing tests and add 2-3 more tests for the new features?