sudolibre commented 5 years ago

Adds tab width prop to allow user to specify tab width as a number or string e.g. 165 or “165”. Also allows user to specify relative percentage width e.g. “20%”
Dry up repeated tab width calculations in JSX by moving the calcultaion to the moment prior to storing in state.
Update indicator and scroll calculations to support smaller tab widths

Default Tab Size default_size

Super Small Tab Size super_small

codecov[bot] commented 5 years ago

Codecov Report

Merging #48 into master will increase coverage by 8.71%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   77.35%   86.07%   +8.71%     
==========================================
  Files           6        6              
  Lines          53       79      +26     
  Branches       11       18       +7     
==========================================
+ Hits           41       68      +27     
+ Misses          9        8       -1     
  Partials        3        3

Impacted Files	Coverage Δ
src/components/MaterialTabs.js	`81.81% <83.33%> (+19.74%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 169d2f1...d2629cf. Read the comment docs.

mohmdalfaha commented 5 years ago

Hi, I am trying to pass a prop ' tabWidth' but nothing changes ??

sudolibre commented 5 years ago

Hi, I am trying to pass a prop ' tabWidth' but nothing changes ??

That's surprising. Are you sure you're on my branch? I'm no longer invested in this so you would need to make any further modifications yourself.

iRoachie commented 5 years ago

Hey @sudolibre I recently updated the lib in 4.0.0 as a typescript rewrite and 4.1.0 that cleans up the logic and supports rtl. You would have tor resubmit this PR.

iRoachie / react-native-material-tabs

Adds tabWidth prop to component #48

Codecov Report