search

iRoachie / react-native-material-tabs

Material Design implementation of Tabs
MIT License
121 stars 56 forks source link

RTL Support #49

Closed saharjedidi closed 5 years ago

saharjedidi commented 5 years ago

the animation for selecting in RTL doesn't support the indicator doesn't show in the second and the third tabs this is the first tab

Screen Shot 2019-04-16 at 10 53 52 AM

but when I choose the next one the indicator doesn't show

Screen Shot 2019-04-16 at 10 54 05 AM
mohmdalfaha commented 5 years ago

@saharjedidi Hi !! Did you find solution for this ??

iRoachie commented 5 years ago

How would I replicate this?

I changed my iOS simulator language to Arabic then ran the example. Everything seems to work as normal.

mohmdalfaha commented 5 years ago

The issue exists only on android devices cuz iOS by default is not set to RTL even if you change the language to Arabic. The underline is not sticky with the tab while moving between tabs. I notice that the direction of the moving tabs is only from left to right. I will share an some screenshot with you soon.

mohmdalfaha commented 5 years ago

I am really sorry for the delay, I ended up making my own tabs component that is more simplified and easy to reason about. I extremely appreciate your work

below is my component:- https://snack.expo.io/@mohmdalfaha/faha---scrollabletoptabbar---enjoy

The support for RTL is really poor and we can only expect individual workarounds. I would invest in this once I am done with some projects.

Thanks anyway,,

iRoachie commented 5 years ago

Just released a new version v4.1.0 that supports RTL. Thanks for the tip about testing RTL on android