search

iRoachie / react-native-material-tabs

Material Design implementation of Tabs
MIT License
121 stars 56 forks source link

fix: Bug where update to selectedIndex would not move indicator #64

Closed iRoachie closed 5 years ago

iRoachie commented 5 years ago

This is because the useEffect which calls selectTab did not have all the dependencies specified.

RIP don't eslint-ignore react-hooks/exhaustive-deps

Fixes #63

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (next@7684195). Click here to learn what that means. The diff coverage is 73.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #64   +/-   ##
=======================================
  Coverage        ?   84.61%           
=======================================
  Files           ?        6           
  Lines           ?       65           
  Branches        ?       19           
=======================================
  Hits            ?       55           
  Misses          ?        6           
  Partials        ?        4
Impacted Files Coverage Δ
src/components/MaterialTabs.tsx 81.57% <73.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7684195...4865afc. Read the comment docs.