search

iRobotEducation / create3_examples

Example nodes to drive the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
51 stars 12 forks source link

Update README.md to include irobot and ros dependancies for ubuntu #49

Closed symmetryninja closed 5 months ago

symmetryninja commented 6 months ago

Added apt install for colcon, galactic teleop joy/keyboard and rplidar packages.

alsora commented 6 months ago

Hi @symmetryninja, I don't think that these commands are needed. The dependencies of the examples are already declared by the respective package.xml files, for example https://github.com/iRobotEducation/create3_examples/blob/galactic/create3_teleop/package.xml#L12C1-L12C1

The build procedure described in the README.md already takes care of them

mkdir -p create3_examples_ws/src
cd create3_examples_ws/src
git clone https://github.com/iRobotEducation/create3_examples.git
cd ..
rosdep install --from-path src --ignore-src -yi
colcon build

Dependencies are installed by the rosdep install --from-path src --ignore-src -yi command

symmetryninja commented 6 months ago

Hi @symmetryninja, I don't think that these commands are needed. The dependencies of the examples are already declared by the respective package.xml files, for example https://github.com/iRobotEducation/create3_examples/blob/galactic/create3_teleop/package.xml#L12C1-L12C1

The build procedure described in the README.md already takes care of them

mkdir -p create3_examples_ws/src
cd create3_examples_ws/src
git clone https://github.com/iRobotEducation/create3_examples.git
cd ..
rosdep install --from-path src --ignore-src -yi
colcon build

Dependencies are installed by the rosdep install --from-path src --ignore-src -yi command

Hey @alsora in my case on a fresh raspberry pi with ubuntu 20.04 and ROS-galactic installed, rosdep did not install those packages for me.