search

iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
110 stars 56 forks source link

WallFollow uses max_runtime Coverage Server Example uses max_duration #130

Closed slowrunner closed 3 years ago

slowrunner commented 3 years ago

It was a little confusing to find the action goal parameter max_runtime for the new wall_follow action, after using max_duration with the coverage server example.

ros2 action send_goal /wall_follow irobot_create_msgs/action/WallFollow "{follow_side: 1, max_runtime:{sec: 1000,nanosec: 0}}"

ros2 action send_goal /coverage create3_examples_msgs/action/Coverage "{explore_duration:{sec: 500, nanosec: 0}, max_duration:{sec: 1000,nanosec: 0}}"

BTW, the wall_follow action is so cool - Thank you, Thank you!

justinIRBT commented 3 years ago

@alsora Should we be consistent between the two? It would be easier to change the example goal.

alsora commented 3 years ago

Yes, I agree on changing the example.

slowrunner commented 3 years ago

Ok - I'll open it on the example. Thanks.