search

iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
110 stars 56 forks source link

Use reliable QoS for publishers #135

Closed eborghi10 closed 2 years ago

eborghi10 commented 2 years ago

We should apply a change that is already being used in gazebo_ros_pkgs, see here.

I used this approach to connect with rosbridge_server for example and with the current configuration, it doesn't work.

[joint_state_publisher-3] /opt/ros/galactic/lib/python3.8/site-packages/rclpy/qos.py:307: UserWarning: DurabilityPolicy.RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL is deprecated. Use DurabilityPolicy.TRANSIENT_LOCAL instead.
rjcausarano commented 2 years ago

@eborghi10 Do you know of any issues that this change will fix? Do we run the risk of introducing new issues?

rjcausarano commented 2 years ago

This might fix https://github.com/iRobotEducation/create3_sim/issues/125

eborghi10 commented 2 years ago

@eborghi10 Do you know of any issues that this change will fix? Do we run the risk of introducing new issues?

On the opposite, I think it'll allow us to use RViz and another tooling.

eborghi10 commented 2 years ago

This might fix #125

@Ednip7 Let's double-check this issue too once you have the changes.