iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
110 stars 56 forks source link

Fix stderr for kidnap estimator node #145

Closed eborghi10 closed 2 years ago

eborghi10 commented 2 years ago

Signed-off-by: Emiliano Borghi creativa_eborghi@irobot.com

Description

This PR fixes a compilation stderr in the kidnap estimator node introduced in #128.

--- stderr: irobot_create_toolbox                                           
/catkin_ws/src/create3_sim/irobot_create_toolbox/src/kidnap_estimator_publisher.cpp: In member function ‘void irobo
t_create_toolbox::KidnapEstimator::kidnap_callback(irobot_create_msgs::msg::HazardDetectionVector_<std::allocator<v
oid> >::SharedPtr)’:       
/catkin_ws/src/create3_sim/irobot_create_toolbox/src/kidnap_estimator_publisher.cpp:58:54: warning: comparison of i
nteger expressions of different signedness: ‘long int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-c
ompare]
   58 |   kidnap_status_msg_.is_kidnapped = wheel_drop_count >= min_wheel_drop_count_ &&
      |                                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
/catkin_ws/src/create3_sim/irobot_create_toolbox/src/kidnap_estimator_publisher.cpp:59:24: warning: comparison of i
nteger expressions of different signedness: ‘long int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-c
ompare]
   59 |     cliff_sensor_count >= min_cliff_sensor_count_;
      |     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ 
---

Type of change

How Has This Been Tested?

Since this is a compilation message, simply compile again:

colcon build --symlink-install

Checklist