Closed civerachb-cpr closed 3 months ago
Overall looks good, thanks for the work! I'll give it a try and do a deeper review in the next days
No big rush. I imagine there may be a few additional updates as I continue testing with the Turtlebot4 packages. But this should give a good base for the remaining Jazzy work.
I did an additional review and, besides the small comments above, everything looks good.
I think I've addressed all the issues raised above.
@civerachb-cpr there's still a few CHANGELOG files that have been inadvertently modified. Can you please revert these changes as well?
Great to see this update. Just wanted to drop https://gazebosim.org/docs/latest/ros2_gz_vendor_pkgs/ in case you haven't seen it. Also, since Gazebo is now available from packages.ros.org, there's no need for the instructions that add the packages.osrfoundation.org repo.
Description
Several fixes & changes needed for Jazzy support:
ign
andignition
related nodes to usegz
orsim
(per new nomenclature)GZ_*
nomenclatureGzSceneManager
andInteractiveViewControl
plugins togui.config
(needed for the visualization to render correctly & allow camera movement)dock
&undock
behaviours could be preempted by e.g.reflex
, causing their associated ROS actions to canceldiff_drive_controller
interaction to useTwistStamped
messages (per recent changes from ROS controllers)NotEqualsSubstitution(...)
withIfCondition(NotEqualsSubstitution(...))
(deprecation)maze
world to ensure the robot's default spawn location doesn't clip intowall 12
How Has This Been Tested?
Tested on Ubuntu 24.04. Able to successfully:
Wait for the simulation to load fully (may take several seconds, depending on the specs of the machine being used), then press the orange
play
button to start the simulation. The fan in the depot ceiling will spin when the simulation is running. Rviz will show the robot & dock.To undock the robot:
To dock the robot: