iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
110 stars 56 forks source link

Jazzy updates #229

Closed civerachb-cpr closed 3 months ago

civerachb-cpr commented 3 months ago

Description

Several fixes & changes needed for Jazzy support:

How Has This Been Tested?

Tested on Ubuntu 24.04. Able to successfully:

# To start the simulation
ros2 launch irobot_create_gz_bringup create3_gz.launch.py

Wait for the simulation to load fully (may take several seconds, depending on the specs of the machine being used), then press the orange play button to start the simulation. The fan in the depot ceiling will spin when the simulation is running. Rviz will show the robot & dock.

To undock the robot:

ros2 action send_goal /undock irobot_create_msgs/action/Undock {}

To dock the robot:

ros2 action send_goal /dock irobot_create_msgs/action/Dock {} --feedback
alsora commented 3 months ago

Overall looks good, thanks for the work! I'll give it a try and do a deeper review in the next days

civerachb-cpr commented 3 months ago

No big rush. I imagine there may be a few additional updates as I continue testing with the Turtlebot4 packages. But this should give a good base for the remaining Jazzy work.

alsora commented 3 months ago

I did an additional review and, besides the small comments above, everything looks good.

civerachb-cpr commented 3 months ago

I think I've addressed all the issues raised above.

alsora commented 3 months ago

@civerachb-cpr there's still a few CHANGELOG files that have been inadvertently modified. Can you please revert these changes as well?

azeey commented 2 months ago

Great to see this update. Just wanted to drop https://gazebosim.org/docs/latest/ros2_gz_vendor_pkgs/ in case you haven't seen it. Also, since Gazebo is now available from packages.ros.org, there's no need for the instructions that add the packages.osrfoundation.org repo.