iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
106 stars 56 forks source link

Generalize gz vendor use and modernize CMake #232

Closed j-rivero closed 1 week ago

j-rivero commented 1 week ago

Description

I was testing the use of upcoming Gazebo Ionic with current jazzy branch (it is using Gazebo Harmonic by default) and found that the use of the new vendor packages could be improved and corrected according to https://gazebosim.org/docs/ionic/ros2_gz_vendor_pkgs/#cmakelists-txt-for-building-with-gazebo-vendor-packages

I've also modernize the CMake a bit to solve problems with exporting the necessary linking.

Type of change

How Has This Been Tested?

I test the compilation using Gazebo Ionic in a docker container.

Checklist

alsora commented 1 week ago

The changes look good to me, but the CI Is failing because it can't find one of the new cmake targets

j-rivero commented 1 week ago

The changes look good to me, but the CI Is failing because it can't find one of the new cmake targets

Ouch sorry. It should be fixed now.

alsora commented 1 week ago

Thanks, there's a few linter errors, would you mind fixing them?

Then we should be good to merge