search

iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot
BSD 3-Clause "New" or "Revised" License
110 stars 56 forks source link

Make sure Galactic is supported #46

Closed rjcausarano closed 3 years ago

rjcausarano commented 3 years ago

In order to fully support Galactic we need a few packages to be officially released. I also noticed that to support Galactic our source code needed a few modifications.

The good news is that these packages can be installed from source and there now exists a PR to address the compatibility changes: https://github.com/iRobotSTEM/create3_sim/pull/53

To run create3 in Galactic please checkout to the above branch and then install the prerequisites from source: https://github.com/iRobotSTEM/create3_sim/blob/7d8e442ba4f765492df050306882d692042504fd/README.md

rjcausarano commented 3 years ago

@eborghi10 @apojomovsky @LolaSegura @lchico @justinIRBT

eborghi10 commented 3 years ago

@rjcausarano Next time, please create the galactic branch with the same changes as in master and, after that, a PR so we can review the changes.

I have a few questions:

  1. Can those changes be applied to Foxy?
  2. Rename the branch to galactic-devel.
  3. We should have a foxy-devel branch too.
  4. We have to define whether we want to keep master or remove it.
  5. The changes need to have a .repos file with ros2_control.
justinIRBT commented 3 years ago

We might want to make a working galactic branch be master and have a foxy branch with the stuff that currently works with foxy

rjcausarano commented 3 years ago

@rjcausarano Next time, please create the galactic branch with the same changes as in master and, after that, a PR so we can review the changes.

I have a few questions:

  1. Can those changes be applied to Foxy?
  2. Rename the branch to galactic-devel.
  3. We should have a foxy-devel branch too.
  4. We have to define whether we want to keep master or remove it.
  5. The changes need to have a .repos file with ros2_control.
rjcausarano commented 3 years ago

@eborghi10 PR created

alsora commented 3 years ago

We might want to make a working galactic branch be master and have a foxy branch with the stuff that currently works with foxy

I think it would be better to keep master as a separate branch from the release ones.

So we would have:

Developement can happen on master. Then changes can be backported from master to galactic if they are worth (e.g. critical bug fixes or non API/ABI breaking changes). When a new release comes out, we should branch from master.

Note that if we want to be fancy, the master branch should acutally target the ROS 2 rolling release (which is kind of a weekly released master)