Fix wheeldrop event publish - Githubissues

iRobotEducation / create3_sim

ROS 2 Simulation for the iRobot® Create® 3 Educational Robot

BSD 3-Clause "New" or "Revised" License

110 stars 56 forks source link

Fix wheeldrop event publish #85

Closed rjcausarano closed 3 years ago

rjcausarano commented 3 years ago

Description

Wheeldrops was reported to have stopped working. This PR solves the issue by fixing the topic that the events were being published to. Fixes #82

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

On the master branch you will see nothing published to the wheeldrop topics when dropping the robot from a small height:

/_internal/wheel_drop/right_wheel/event
/_internal/wheel_drop/left_wheel/event

After checking out to this commit the same test will throw the desired results

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

rjcausarano commented 3 years ago

@apojomovsky @eborghi10 @lchico @LolaSegura PTAL

rjcausarano commented 3 years ago

@apojomovsky @lchico @LolaSegura Can I get a review please?