iRohitSingh / Twenty-Twenty-themes-

0 stars 1 forks source link

Code improvements #2

Open jackahl opened 2 years ago

jackahl commented 2 years ago

I've found a few things in your Code that you could improve: custom.less: use less variables for colors and responsive breakpoints

create custom.variables file to define your own .less variables

Footer and Header: use the volto icon, like e.g. here: https://github.com/plone/volto/blob/7890beb6ee24547afd50d06d2597fa88c6bd5f50/src/components/manage/Contents/ContentsItem.jsx#L97