Open iRove108 opened 4 years ago
Hi Alex, I like your idea for the library! I tried testing out your code for green highlights. I was a bit confused about how to test and run the code, so here're some suggestions about this issue to help future contributors:
import cv2
before running the program? python main.py
in the Terminal, I got the error saying that there'sNo module named markups
The library should install OpenCV when it is installed with pip
. Additionally, for others having the same problem as the previous poster mentioned in their third bullet, please see this issue.
Main.py for the highlight extraction example uses the default lower and upper HSV bounds, as specified in highlighting.py. These bounds have been fine-tuned for a standard yellow highlighter. This is why the example works well on this image. However, it may be possible to get the code to work for different colors as well. After installing the package as described in the README:
image_green_highlight.jpg
main_green_highlight.py
image.jpg
(relevant line)lowerb
andupperb
arguments when creating the HighlightExtractor (arrays of form[H, S, V]
)It's okay if this doesn't work perfectly! It might not—I've only tested the code with yellow highlighting colors. Nonetheless, you can still create the PR to demonstrate how well the library does/doesn't work for other colors.