search

iSach / UltraCosmetics

Lightweight, Fun and Easy-to-Use Spigot Cosmetics plugin. (Gadgets, etc)
https://www.spigotmc.org/resources/ultra-cosmetics-halloween-update.10905/
GNU Affero General Public License v3.0
165 stars 157 forks source link

Replaced items are lost #440

Closed s1h4d0w closed 5 years ago

s1h4d0w commented 5 years ago

Expanding on this issue: https://github.com/iSach/UltraCosmetics/issues/438

What steps will reproduce the issue?

  1. Have a full inventory and wear a chestplate
  2. Use for example the Witch morph
  3. Remove your cosmetics
  4. Chestplate is nowhere to be found

-or-

  1. Have a full inventory
  2. Equip a gadget
  3. Unequip that gadget
  4. Item that was replaced in your hotbar isn't returned

What was supposed to happen?

The items being returned to the player

What happened?

The item wasn't returned to the player

What version of UltraCosmetics are you using?

2.4.11

What Spigot version are you using? Paste the output of /version below.

CraftBukkit version git-Spigot-79a30d7-acbc348 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

What plugins do you have installed? Paste the output of /plugins below.

KeepItems, PlaceholderAPI, ArmoredElytra, ConsoleSpamFix, SkinsRestorer, AutoRestart, CoreProtect, ClearLag, ChatControl, Genie, ProtocolLib, Multiverse-Core, LibsDisguises, FastAsyncWorldEdit, commandDelay, PermissionsEx, AntiBuild, ServerListPlus, Vault, PlayerMarkers, UltraCosmetics, Matrix, PerWorldInventory, HolographicDisplays, HeadsPluginAPI, PlayerEmotesPro, MyCommand, WorldEdit, Orebfuscator4, NoSwear, AdvancementMoney, Essentials, AutoMessager, OnTime, WorldEditSelectionVisualizer, TouchscreenHolograms, HeadsInventory, WorldGuard, MobStacker, Shop, BetterRTP, EssentialsSpawn, WorldGuardExtraFlags, SilkSpawners, DenyTP, ChopTree3, GriefPrevention, AuthMe, CrazyEnchantments

Are any errors related to UltraCosmetics in your console or logs? If so, paste below.

[04:10:09 INFO]: [LibsDisguises] Enabling LibsDisguises v9.5.2
[04:10:09 INFO]: [LibsDisguises] Discovered nms version: v1_12_R1
[04:10:09 WARN]: Mismatch of FlagType's for ENDER_CRYSTAL! Index 6 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityEnderCrystal) & EnderCrystalWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for ENDERMAN! Index 12 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityEnderman) & EndermanWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for HORSE! Index 14 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityHorse) & HorseWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for LLAMA! Index 14 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityLlama) & LlamaWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for OCELOT! Index 14 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityOcelot) & OcelotWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for PARROT! Index 14 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityParrot) & ParrotWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for SHULKER! Index 13 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityShulker) & ShulkerWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 WARN]: Mismatch of FlagType's for WOLF! Index 14 has the wrong classtype!
[04:10:09 WARN]: MetaIndex has the default of Optional.empty (class java.util.Optional) (class net.minecraft.server.v1_12_R1.EntityWolf) & WolfWatcher
[04:10:09 WARN]: Where the internals is Optional.absent() (class com.google.common.base.Absent
[04:10:09 WARN]: Lib's Disguises will continue to load, but this will not work properly!
[04:10:09 INFO]: [LibsDisguises] Loaded custom disguise libraryaddict
[04:10:09 INFO]: [LibsDisguises] Loaded 1 custom disguise

Any additional information that you would like to provide that may be relevant to the issue?

I've disabled morphs for now, and have also disabled the wither pet as players managed to kill it and have it drop a nether star, and I've disabled the flying mounts. Would greatly appreciate a feature to allow those mounts, without flight. And if fixing the wither killing is hard, maybe it's easier to just not make it drop anything?

iSach commented 5 years ago

It should drop the item. Can you confirm it still happens on latest UC version? If the server denies the item to be dropped. Then this can be an issue but the user shouldn't have a full inventory where dropping isn't allowed (like hubs) I guess?

s1h4d0w commented 5 years ago

Seems to be fixed in the latest version! I've switched over to a 1.14 server so I don't know if it still persists on 1.12.