search

iSach / UltraCosmetics

Lightweight, Fun and Easy-to-Use Spigot Cosmetics plugin. (Gadgets, etc)
https://www.spigotmc.org/resources/ultra-cosmetics-halloween-update.10905/
GNU Affero General Public License v3.0
166 stars 153 forks source link

Consider switching from UCMaterial to XMaterial #570

Closed datatags closed 2 years ago

datatags commented 2 years ago

XMaterial

Why?

UCMaterial hasn't been touched since 1.14.4 by the look of it, meaning it doesn't support any items that have been added since then. Plus, UCMaterial is quite messy in some areas, and switching to XMaterial means one less (large) thing we have to maintain.

Alternatives

  1. Ignore UCMaterial, resulting in no new items available for use in the GUI or treasure chest structures.
  2. Continue maintaining UCMaterial, which seems like a large project.
  3. ??
datatags commented 2 years ago

Re-reading the UCMaterial class, it appears to actually be derived from XMaterial a few years ago. It'd be nice to be able to shade it using Gradle so it can stay up-to-date.