iScsc / iscsc.fr

The iScsc website, build with passion by wannabe devs 🔥
GNU General Public License v3.0
4 stars 12 forks source link

Update gitignore #84

Closed atxr closed 1 year ago

atxr commented 1 year ago

Regarding the recents PR merged, the gitignore isn't up to date.

I added:

ctmbl commented 1 year ago

@atxr Actually the bump script doesn't run npm install at root and then shouldn't create such node_modules and package-lock.json at root :thinking: I just tried it :shrug:

atxr commented 1 year ago

You are right, not explicitly, but we need semver, which is installed via npm. And if you don't want it globally the best place is at the root I guess. I don't know how did you deal with this 🤔

atxr commented 1 year ago

This file contains the gpg keys of all the team for using the gpg_share script I thought we agreed on the file name, and if not this is my proposition :wink:

ctmbl commented 1 year ago

You are right, not explicitly, but we need semver, which is installed via npm. And if you don't want it globally the best place is at the root I guess. I don't know how did you deal with this thinking

I actually installed it globally, but you're right let's cover every cases possible, which makes me removing my statement https://github.com/iScsc/iscsc.fr/pull/83#discussion_r1154435355 of #83

I thought we agreed on the file name, and if not this is my proposition wink

I personally like this!