Closed ctmbl closed 1 year ago
Note once we land #91 and the
prettier
pipeline is fixed, you cangit fetch iscsc git merge iscsc/main git push ctmbl
to resolve the conflicts if any @ctmbl :+1:
@amtoine ofc I'll do it, anyway the CI won't pass if I don't :+1:
I simply refactored the
Dockerfile
and replace any use ofnode-*
bybackend-*
orflask-*
, for example for container name, env variable etc, I also added arequirements.txt
for obvious reasons.To go further: I chose
flask
as future python backend framework out of these propositionsTwo parts of a DigitalOcean
flask
tutorial, we could find useful:flask
app part 1/13flask
part 8/13Currently the only thing that can be done is run the
docker-compose
command described in theREADME.md
, without certificates (raw HTTP, after reverting #34 withgit revert 8087def
for example), and it builds and run without errors. Of course, none of the endpoints the frontend try to reach are currently implemented, it doesn't even use the right port, but this setup the environment to build upon!We have 3 solutions described to configure the port:
flask
env var on StackOveflow or on DigitalOcean's tuto --> the one we should use according to meapp.py
in python (doesn't useflask
CLI) --> reliable but seems like a hacky solution :shrug:But all this will be work for other PRs to
backend/python
:warning: IMPORTANT: i've read everywhere that the way I currently run the server (
flask run
) is not the proper way to do it in production, will have to investigate further! (for example serve flask with Gunicorn and Nginx)