search

iScsc / iscsc.fr

The iScsc website, build with passion by wannabe devs 🔥
GNU General Public License v3.0
4 stars 12 forks source link

Migrate database to localhost #92

Closed atxr closed 1 year ago

atxr commented 1 year ago

This PR removes the hardcoded values of the remote atlas database. It introduces a new local database deployment in the docker-compose workflow. The database is secured thanks to docker networking.

I tested the whole migration :heavy_check_mark:

:warning: This PR doesn't migrate the current atlas db to the new local one. This action must be done "by hand" when the website will be bumped.

amtoine commented 1 year ago

Note once we land #91 and the prettier pipeline is fixed, you can

git fetch iscsc
git merge iscsc/main
git push atxr

to resolve the conflicts if any @atxr :+1:

atxr commented 1 year ago

i'll trust you when you say you have tested it => do you think we could test that part of the website during some deployment pipeline?

What do you mean by testing it during some deployment pipeline?

amtoine commented 1 year ago

What do you mean by testing it during some deployment pipeline?

well you're saying me you've updated the database, performed local manual tests and that it must 'be done "by hand"' to deploy the website on the server.

i'm wondering if there is some kind of GitHub pipeline we could write to test

atxr commented 1 year ago

Ok yes I see! Actually we don't have any test to verify that the backend/frontend/database is successfully deployed But I guess it's a good next step for the CI The migration of the database from atlas to localhost will be done only once and I'll probably write a little script to do so when we will deploy the website

amtoine commented 1 year ago

Actually we don't have any test to verify that the backend/frontend/database is successfully deployed But I guess it's a good next step for the CI

could you file an issue for this? :yum:

The migration of the database from atlas to localhost will be done only once and I'll probably write a little script to do so when we will deploy the website

ok gotcha, no need to spend too much time on that particular migration then :relieved: but a general CI that checks the deployment might be great.

atxr commented 1 year ago

could you file an issue for this? yum

Actually no, because we have a bigger plan for the CI with @ctmbl We will create an issue soon