iSlammedMyKindle / twitchToDiscordBot

Cross-platform messaging interface between discord and twitch chats
0 stars 2 forks source link

Improve formatting #26

Open MiguelHigueraDev opened 4 days ago

MiguelHigueraDev commented 4 days ago

I think that even though the formatting is serviceable, it could be improved a lot by using a twitch emoji and a bold font for the username, like this:

image

I think it's an upgrade over this:

image

You may disagree, I would like to hear your input.

iSlammedMyKindle commented 4 days ago

It seems like a very interesting idea; There are a couple of things I would want to consider in order to do something like this:

MiguelHigueraDev commented 4 days ago

Ah yeah, the first point is a good one, it's something I didn't consider.

I could consider the second point as well, but I don't know if it would look good, most chat applications put the sender on every message. The other option would be to use webhooks and send a message with the twitch username instead of twitchToDis or whatever the bot is called, that would be more like how Discord handles messages by the same user.

And about the third point yeah I forgot to mention it, it would be a change applied only to the Discord side of the program.

iSlammedMyKindle commented 4 days ago

It depends on the application from what I recall, it could probably be up for preference.

iMessage is one example where they tend to be very minimal with bubble design. They tend not to show names in the first place with 1-1s, but in group texts, they will show a bubble showing who most recently talked.

Minecraft is on the opposite spectrum, where it shows a username after every message. When I think of minecraft, it feels a lot like how IRC behaves, or twitch for that matter.

Discord will only show the username of a person after a message if there was at least 2-5 minutes of inactivity between messages. Given that twitch messages are now being sent over to discord, it might make sense to retain the paradigm that discord tries to do with minimalism and remove the username after more than one message.

Ultimately though it's up for preference, Though at the end of the day it's not super related to the minimum scope which is to format the message differently

MiguelHigueraDev commented 4 days ago

I would just implement it sending the username with every message and making sure there is a way to specify what emoji would be used.

Later we could take a look into doing it using webhooks, because I think we would need to rewrite certain parts of the code, instead of just changing the formatting and adding a property to the configuration file.

If you agree with this, I'd be glad to send you a PR with the changes.

iSlammedMyKindle commented 4 days ago

You're more than welcome to give it a shot! The only pre-requisite that's needed for this repo would be to make sure the bot is able to be tested & deployed using a personal dev environment. Previous contributers tried to send code without testing; so it will be asked if it's tested before merge! 👍