search

iSoron / uhabits

Loop Habit Tracker, a mobile app for creating and maintaining long-term positive habits
GNU General Public License v3.0
7.95k stars 939 forks source link

Issue 1779: Showing month in HeaderView calendar #1780

Closed kalina559 closed 9 months ago

kalina559 commented 1 year ago

Solves #1779. Not sure about this one though, it could be useful when scrolling a long way back in the Header View calendar, but it basically shows the same thing for every day of the month. Below is the comparison of the current app (1), the code in this pull request (2) and a third option that would show the month only for first/last day of the month (3). Please let me know which one makes the most sense for you.

1. MicrosoftTeams-image (22)

2. MicrosoftTeams-image (23)

3. MicrosoftTeams-image (24)

kalina559 commented 1 year ago

@iSoron @hiqua I know a lot of tests started failing now, but before I fix them let me know if this change makes sense :)

hiqua commented 1 year ago

The main drawback is that it takes more space, so you can visualize less habits at the same time. Maybe that's fine though? Wondering if we could have the month on the same row as the date instead. I don't have a strong opinion on this though, so fine for me. @iSoron?

P.S.: for next time, if you could have screenshots in English, that'd make it easier to have an idea of what your changes do!

iSoron commented 9 months ago

Thanks for the PR, @kalina559. I'm not a huge fan of this layout as (i) it occupies more space; (ii) the month row will show the same text repeatedly, in the vast majority of situations. I agree that it would be nice to display the month sometimes, but I suggest doing what we currently do for the charts: on January 1, 2024, for example, we could show "Jan \ 1" instead of "Monday \ 1".