search

iTXTech / SynapsePM

Synapse client for PocketMine like server software. Supports multiple connections.
21 stars 17 forks source link

Incompatible with pmmp #24

Closed jarne closed 7 years ago

jarne commented 7 years ago

As I remember, it worked with pmmp some time ago. Now I'm getting this error, because CID bans has been removed from pmmp (where they ever implemented?).

[18:38:06] [Server thread/CRITICAL]: Could not execute task synapsepm\TickSynapseTask: Call to undefined method pocketmine\Server::getCIDBans()
[18:38:06] [Server thread/CRITICAL]: Error: "Call to undefined method pocketmine\Server::getCIDBans()" (EXCEPTION) in "/SynapsePM_v1.0.3.phar/src/synapse/Player" at line 93
dktapps commented 7 years ago

No, CID ban has never been a PocketMine feature.

jarne commented 7 years ago

Okay, then it looks like it was never compatible with PocketMine, @Tarik02 wrote on https://github.com/iTXTech/Genisys/pull/2138: "@dktapps, I tested this with pmmp/PocketMine-MP and it works good."

tarik02 commented 7 years ago

Thanks, this will be fixed soon.

NyaomiDEV commented 7 years ago 
[18:47:36] [Server thread/CRITICAL]: Could not pass event 'pocketmine\event\player\PlayerInteractEvent' to 'VISmartBar v0.0.1': Call to undefined method synapse\Player::getItemInHand() on VISmartBar\Main
[18:47:36] [Server thread/CRITICAL]: Error: "Call to undefined method synapse\Player::getItemInHand()" (EXCEPTION) in "/plugins/VISmartBar/src/VISmartBar/Main" at line 87

It has a lot of player instance issues like this one

tarik02 commented 7 years ago

@AryToNeX, this is not SynapsePM issue.

jarne commented 7 years ago

@AryToNeX You're importing the wrong Player class. synapse\Player has no getItemInHand(), but pocketmine\Player has. This can also be fixed by replacing use synapse\Player with use synapse\Player as SynapsePlayer.

NyaomiDEV commented 7 years ago

Nope guys, I didn't import synapse/Player at all, this is happening with PlayerInteractEvent::getPlayer()

I think SynapsePM tells PocketMine to override in some way the pocketmine\Player class with his class and this is the result.