iTaxoTools / TaxI2

Calculation and analysis of pairwise sequence distances
GNU General Public License v3.0
0 stars 0 forks source link

Small probable typo in Rust version #8

Closed mvences closed 3 years ago

mvences commented 3 years ago

I have now been able to get the Rust version running on my Windows 10 computer, which is great.

Before merging the Rust branch, there are a few minor changes that I think should be applied:

  1. In the file copy_rust_lib.py it says twice: src_path = os.path.join(src_path, "libcalculate_distances.dll")

However, there is no libcalculate_distances.dll

I have changed this to calculate_distances.dll

then I could execute the command python copy_rust_lib.py

and after this the program worked. So I think this is probably a typo in the script?

  1. There are two more typos in the Readme file: platfom.architecture should be platform.architecture and instead of TaxI2 it should now read TaxI3

It would be good if you also fix these two small things to make sure they are not forgotten.

After this, I suggest you can just merge the various branches so that the TaxI3 main branch contains the latest version of the Rust-implementing program.