search

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.09k stars 293 forks source link

refactor Feature #1295

Open gchoqueux opened 4 years ago

gchoqueux commented 4 years ago

add properties like: vertices, normal, crs and remove feature from function params.

I'm not convinced by this, because in some case that would be a lot of parameters. See this function: we need the crs, vertices and then normals and size in the _extendBuffer call. WDYT ?

Originally posted by @zarov in https://github.com/iTowns/itowns/pull/1290#issuecomment-574115676

gchoqueux commented 4 years ago

Feature needs a refactoring, we have the necessary hindsight. There is a need to simplify/clarify the code and encapsulate this part of the code.