Refactoring inheritance Style

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data

http://www.itowns-project.org

Other

1.09k stars 293 forks source link

Refactoring inheritance Style #1739

Open gchoqueux opened 2 years ago

gchoqueux commented 2 years ago

Actually the inheritance Style uses a parent property.

It seems that the feature styles cannot be used with multiple layers.

We would have to find another mechanism of cascading inheritance.

_Originally posted by @gmaillet in https://github.com/iTowns/itowns/pull/1736#discussion_r741711525_

jailln commented 1 year ago

Related to #1924

Desplandis commented 3 months ago

@ftoromanoff Your style refactoring fixes this, right?

ftoromanoff commented 3 months ago

It should, at least for part of it. The style refactorign did supprese the parent property and change the cascading inheritance. But not sure about the 'It seems that the feature styles cannot be used with multiple layers.' as i don't really get what it refers to..