search

iTowns / itowns

A Three.js-based framework written in Javascript/WebGL for visualizing 3D geospatial data
http://www.itowns-project.org
Other
1.09k stars 293 forks source link

Custom points shapes #2173

Closed Pourfex closed 1 year ago

Pourfex commented 1 year ago

Description

Add an option to render point in shapes of Square or Circle.

Motivation and Context

We've made this change so we can have the same behaviour as Potree's examples. Square point shape provides a better rendering in our use cases.

Screenshots

Circle point shape :

image

Square point shape :

image
AnthonyGlt commented 1 year ago

Is this MR finished ? You can notify the reviewer when it's the case: image

FYI, we usually keep only 1 commit per feature/bug fix. I'll squash your commits into one when I'll merge. Next time, when you consider your MR as completed, feel free to rebase your commit into 1 and keep 1 commit message. It means that the intermediary commit messages don't have to follow the commit message syntax because they will get squashed

Pourfex commented 1 year ago

@AnthonyGlt MR is ready ! Feel frew to review. Got it for next times, hope we can do more contributions.